Paths

Table of Contentst

Differential D11936

Remove magic "help" in global search
ClosedPublic
Actions

Authored by epriestley on Mar 2 2015, 10:17 PM.

Tags

None

Referenced Files

	F15494303: D11936.id28753.diff
	Sat, Apr 12, 11:11 PM

	F15494302: D11936.id28752.diff
	Sat, Apr 12, 11:10 PM

	F15489199: D11936.id28754.diff
	Fri, Apr 11, 6:48 AM

	F15487084: D11936.id.diff
	Thu, Apr 10, 11:07 AM

	F15485196: D11936.diff
	Wed, Apr 9, 10:29 PM

	F15458564: D11936.diff
	Mon, Mar 31, 4:50 AM

	F15448603: D11936.id28752.diff
	Fri, Mar 28, 5:54 AM

	F15386525: D11936.id28753.diff
	Sat, Mar 15, 12:46 AM

Subscribers

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7425: Searching literal "help" 503's without diviner installed (best guess)

Commits

Restricted Diffusion Commit
rPa6ec787df595: Remove magic "help" in global search

Summary

Fixes T7425. Overall, this is surprising and confusing after jump nav was merged with global search.

Test Plan

Searched for "help", got documents matching the word "help".

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28752.Mar 2 2015, 10:17 PM

epriestley retitled this revision from to Remove magic "help" in global search.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T7425: Searching literal "help" 503's without diviner installed (best guess).

Herald added a subscriber: epriestley. · View Herald TranscriptMar 2 2015, 10:17 PM

Also unhijack the word "symbol". You can use "s idx" to find the idx() symbol, and it shows up in the typeahead anyway.
Remove help from documentation.

I have no authority here and I approve this message :)

btrahan accepted this revision.Mar 2 2015, 10:24 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 2 2015, 10:24 PM

Closed by commit rPa6ec787df595: Remove magic "help" in global search (authored by epriestley, committed by epriestley). · Explain WhyMar 2 2015, 10:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

engine/

PhabricatorJumpNavHandler.php

30 lines

docs/

user/

userguide/

1 line

Diff 28754

src/applications/search/engine/PhabricatorJumpNavHandler.php

Loading...

src/docs/user/userguide/jump.diviner

Loading...