Differential D11923

Allow un-ToS'd users to view other Legalpad documents
ClosedPublic
Actions

Authored by epriestley on Mar 2 2015, 2:43 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T7420: Before you sign the ToS, you should still be able to view other legalpad documents

Commits

Restricted Diffusion Commit
rP2387c1e9186b: Allow un-ToS'd users to view other Legalpad documents

Summary

Fixes T7420. On Phacility, our ToS currently links to some policy documents, but users who haven't signed the ToS can't see them.

I've just created a blanket exemption and documented it; I think this is reasonable in all cases.

Test Plan

As an un-ToS'd user, viewed some other documents.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28725.Mar 2 2015, 2:43 PM

epriestley retitled this revision from to Allow un-ToS'd users to view other Legalpad documents.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7420: Before you sign the ToS, you should still be able to view other legalpad documents.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 2 2015, 2:43 PM

btrahan accepted this revision.Mar 2 2015, 3:25 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 2 2015, 3:25 PM

Closed by commit rP2387c1e9186b: Allow un-ToS'd users to view other Legalpad documents (authored by epriestley, committed by epriestley). · Explain WhyMar 2 2015, 3:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

legalpad/

controller/

LegalpadDocumentSignController.php

4 lines

docs/

user/

userguide/

legalpad.diviner

45 lines

Diff 28732

View Options

src/applications/legalpad/controller/LegalpadDocumentSignController.php