Page MenuHomePhabricator
Differential D11922

Fix ambiguous column names in Maniphest blocking queries
ClosedPublic
Actions

Authored by epriestley on Mar 2 2015, 2:24 PM.
Tags
None
Referenced Files
F15458201: D11922.diff
Sun, Mar 30, 9:37 PM
F15444133: D11922.id28724.diff
Thu, Mar 27, 8:00 AM
F15420332: D11922.id28726.diff
Fri, Mar 21, 1:09 PM
F15417779: D11922.id28724.diff
Thu, Mar 20, 6:26 PM
F15415850: D11922.id28724.diff
Thu, Mar 20, 7:59 AM
F15400863: D11922.id.diff
Mon, Mar 17, 2:24 PM
F15396509: D11922.diff
Sun, Mar 16, 2:50 PM
F15384523: D11922.id28726.diff
Fri, Mar 14, 8:08 PM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
btrahan
chad
Maniphest Tasks
T7421: "Column 'status' in where clause is ambiguous" error when attempting to search for unblocked tasks
Commits
Restricted Diffusion Commit
rPbb6eb9bfcf52: Fix ambiguous column names in Maniphest blocking queries
Summary

Fixes T7421. Now that we join the task table again to ignore closed blockers, all the column names are ambiguous. Make them unambiguous.

Test Plan

Issued some searches with various different parameters.

Diff Detail

Repository
rP Phabricator
Branch
task1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4698
Build 4712: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28724.Mar 2 2015, 2:24 PM
epriestley retitled this revision from to Fix ambiguous column names in Maniphest blocking queries.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
epriestley added a task: T7421: "Column 'status' in where clause is ambiguous" error when attempting to search for unblocked tasks.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 2 2015, 2:24 PM
chad accepted this revision.Mar 2 2015, 2:36 PM
chad added a reviewer: chad.
This revision is now accepted and ready to land.Mar 2 2015, 2:36 PM
Closed by commit rPbb6eb9bfcf52: Fix ambiguous column names in Maniphest blocking queries (authored by epriestley, committed by epriestley). · Explain WhyMar 2 2015, 2:43 PM
This revision was automatically updated to reflect the committed changes.
chad mentioned this in T7563: Dragging tasks on Maniphest appear in the wrong position (n+1).Mar 20 2015, 11:42 PM

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
query/
52 lines

Diff 28724

View Options

src/applications/maniphest/query/ManiphestTaskQuery.php

Loading...
Phabricator · Built by Phacility