Page MenuHomePhabricator
Differential D11911

Exclude closed tasks from blocked/blocking filter
ClosedPublic
Actions

Authored by joshuaspence on Feb 28 2015, 12:05 PM.
Tags
None
Referenced Files
F14102054: D11911.id28694.diff
Tue, Nov 26, 5:42 PM
Unknown Object (File)
Sun, Nov 24, 11:24 AM
Unknown Object (File)
Sat, Nov 23, 11:08 PM
Unknown Object (File)
Sat, Nov 23, 10:35 PM
Unknown Object (File)
Tue, Nov 19, 11:37 AM
Unknown Object (File)
Fri, Nov 8, 8:38 PM
Unknown Object (File)
Oct 26 2024, 9:14 PM
Unknown Object (File)
Oct 19 2024, 12:59 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7392: Custom filter condition "Show Tasks Not Blocked By Other Tasks" does not show tasks whose blocked tasks are all completed
Commits
Restricted Diffusion Commit
rP130aa755bb0e: Exclude closed tasks from blocked/blocking filter
Summary

Fixes T7392. When filtering blocked/blocking Maniphest tasks, don't consider closed tasks.

Test Plan
  1. Created T1 and T2 with T2 depends on T1.
  2. Marked T1 as resolved.
  3. Searched for tasks "blocked by other tasks" and noted that T2 wasn't in the result set.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 28690.Feb 28 2015, 12:05 PM
joshuaspence retitled this revision from to Exclude closed tasks from blocked/blocking filter.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added reviewers: epriestley, btrahan.
joshuaspence added a task: T7392: Custom filter condition "Show Tasks Not Blocked By Other Tasks" does not show tasks whose blocked tasks are all completed.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 28 2015, 12:05 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Feb 28 2015, 9:51 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/maniphest/query/ManiphestTaskQuery.php
807

For consistency, consider omitting the keyword INNER, as JOIN on its own means INNER JOIN and we omit INNER elsewhere.

This revision is now accepted and ready to land.Feb 28 2015, 9:51 PM
joshuaspence updated this revision to Diff 28693.Feb 28 2015, 10:40 PM
joshuaspence edited edge metadata.

Use JOIN instead of INNER JOIN

Closed by commit rP130aa755bb0e: Exclude closed tasks from blocked/blocking filter (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 28 2015, 10:41 PM
This revision was automatically updated to reflect the committed changes.
mpalmer mentioned this in T7421: "Column 'status' in where clause is ambiguous" error when attempting to search for unblocked tasks.Mar 2 2015, 8:26 AM

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
query/
16 lines

Diff 28694

View Options

src/applications/maniphest/query/ManiphestTaskQuery.php

Loading...
Phabricator · Built by Phacility