Differential D11910

Re-enable the deprecated calls setup check
ClosedPublic
Actions

Authored by joshuaspence on Feb 28 2015, 11:45 AM.

Details

Reviewers

epriestley
btrahan

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPec12b710aac0: Re-enable the deprecated calls setup check

Summary

This reverts commit 55c00ebfa125199e4914e98574950e6111a416d7. T7111, T7112 and T7113 have all been resolved now.

Test Plan

Maybe wait a few more weeks... I just wanted to ensure that this wasn't forgotten.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 28689.Feb 28 2015, 11:45 AM

joshuaspence retitled this revision from to Re-enable the deprecated calls setup.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added reviewers: epriestley, btrahan.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 28 2015, 11:45 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence retitled this revision from Re-enable the deprecated calls setup to Re-enable the deprecated calls setup check.Feb 28 2015, 10:50 PM

joshuaspence edited edge metadata.

This is maybe okay now?

epriestley accepted this revision.Apr 6 2015, 1:31 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 6 2015, 1:31 PM

Closed by commit rPec12b710aac0: Re-enable the deprecated calls setup check (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 7 2015, 8:09 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

check/

ConduitDeprecatedCallSetupCheck.php

4 lines

Diff 29576

View Options

src/applications/conduit/check/ConduitDeprecatedCallSetupCheck.php

Re-enable the deprecated calls setup checkClosedPublicActions