Page MenuHomePhabricator
Differential D11865

Track daemon unique IDs in Phabricator daemon logs
ClosedPublic
Actions

Authored by epriestley on Feb 23 2015, 7:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 1, 4:53 PM
Unknown Object (File)
Mon, Dec 30, 8:58 AM
Unknown Object (File)
Sun, Dec 29, 6:53 AM
Unknown Object (File)
Sun, Dec 22, 4:02 AM
Unknown Object (File)
Sat, Dec 21, 9:59 AM
Unknown Object (File)
Dec 15 2024, 7:43 PM
Unknown Object (File)
Dec 15 2024, 4:14 AM
Unknown Object (File)
Dec 12 2024, 2:23 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7352: Improve daemon scalability in the cluster
Commits
Restricted Diffusion Commit
rPa354e5fa6b94: Track daemon unique IDs in Phabricator daemon logs
Summary

Ref T7352. We were previously identifying things by <daemonClass, overseerPID, startTime> but that's not unique in a world where one overseer can run multiple daemons.

We already have an internal "daemonID", it just doesn't get written into the DB right now.

Start writing it, then use it to clean up phd status.

Test Plan

Ran phd status, got more accurate/useful output than previously.

Diff Detail

Repository
rP Phabricator
Branch
daemon8
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4619
Build 4633: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28581.Feb 23 2015, 7:28 PM
epriestley retitled this revision from to Track daemon unique IDs in Phabricator daemon logs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7352: Improve daemon scalability in the cluster.
Herald added a subscriber: epriestley. · View Herald TranscriptFeb 23 2015, 7:28 PM
btrahan accepted this revision.Feb 24 2015, 5:15 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 24 2015, 5:15 PM
Closed by commit rPa354e5fa6b94: Track daemon unique IDs in Phabricator daemon logs (authored by epriestley, committed by epriestley). · Explain WhyFeb 24 2015, 10:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28581

View Options

resources/sql/autopatches/20150223.daemon.1.id.sql

Loading...
View Options

resources/sql/autopatches/20150223.daemon.2.idlegacy.sql

Loading...
View Options

resources/sql/autopatches/20150223.daemon.3.idkey.sql

Loading...
View Options

src/applications/daemon/event/PhabricatorDaemonEventListener.php

Loading...
View Options

src/applications/daemon/management/PhabricatorDaemonManagementStatusWorkflow.php

Loading...
View Options

src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php

Loading...
View Options

src/applications/daemon/query/PhabricatorDaemonLogQuery.php

Loading...
View Options

src/applications/daemon/storage/PhabricatorDaemonLog.php

Loading...
View Options

src/infrastructure/daemon/control/PhabricatorDaemonReference.php

Loading...
Phabricator · Built by Phacility