Fix fatal in XHProf
AbandonedPublic
Actions

Authored by chad on Feb 20 2015, 10:03 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 11, 10:02 AM

	Unknown Object (File)
	Feb 18 2024, 6:54 PM

	Unknown Object (File)
	Jan 3 2024, 8:21 PM

	Unknown Object (File)
	Dec 30 2023, 6:54 PM

	Unknown Object (File)
	Dec 26 2023, 9:11 PM

	Unknown Object (File)
	May 27 2023, 9:11 AM

	Unknown Object (File)
	Feb 15 2023, 5:18 AM

	Unknown Object (File)
	Sep 24 2022, 10:23 AM

View All 51 Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Summary

4th times the charm? There is some confusion with Headers that could be simplified, obviously.

Test Plan

Looked up PHUIObjectBoxView and verified the correct method to use.

Diff Detail

Repository

rP Phabricator

Branch

xhprof-round-4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4588
Build 4602: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28536.Feb 20 2015, 10:03 PM

chad retitled this revision from to Fix fatal in XHProf.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 20 2015, 10:03 PM

epriestley accepted this revision.Feb 20 2015, 10:03 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 20 2015, 10:03 PM

I was in the wrong branch here, sending new diff

Revision Contents
Changeset List

Path

Size

src/

applications/

xhprof/

view/

PhabricatorXHProfProfileSymbolView.php

2 lines

Diff 28536

View Options

src/applications/xhprof/view/PhabricatorXHProfProfileSymbolView.php

Fix fatal in XHProfAbandonedPublicActions