Page MenuHomePhabricator
Differential D11802

Make icons in tags more floaty, less absoluty
ClosedPublic
Actions

Authored by chad on Feb 18 2015, 7:26 PM.
Tags
None
Referenced Files
F14359666: D11802.diff
Fri, Dec 20, 9:35 AM
Unknown Object (File)
Sun, Dec 15, 1:20 AM
Unknown Object (File)
Fri, Dec 13, 12:53 AM
Unknown Object (File)
Tue, Dec 3, 1:39 PM
Unknown Object (File)
Tue, Dec 3, 12:54 PM
Unknown Object (File)
Wed, Nov 27, 2:13 AM
Unknown Object (File)
Sat, Nov 23, 4:30 AM
Unknown Object (File)
Nov 19 2024, 8:49 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rPeefead772135: Make icons in tags more floaty, less absoluty
Summary

This change wraps the icon inline with the text, so smaller width icons have equal spacing between the border and text.

Test Plan

review a number of different tag with icons, also UIExamples.

pasted_file (101×277 px, 11 KB)

Diff Detail

Repository
rP Phabricator
Branch
phui-tag-view
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4538
Build 4552: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 28450.Feb 18 2015, 7:26 PM
chad retitled this revision from to Make icons in tags more floaty, less absoluty.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 18 2015, 7:26 PM
epriestley accepted this revision.Feb 18 2015, 7:26 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 18 2015, 7:26 PM
chad edited the test plan for this revision. (Show Details)Feb 18 2015, 7:27 PM
chad edited edge metadata.
Closed by commit rPeefead772135: Make icons in tags more floaty, less absoluty (authored by chad, committed by chad). · Explain WhyFeb 18 2015, 7:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
view/
phui/
6 lines
webroot/
rsrc/
css/
phui/
20 lines

Diff 28450

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUITagView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-tag-view.css

Loading...
Phabricator · Built by Phacility