Fix bad Phortune Subscriptions query
ClosedPublic
Actions

Authored by epriestley on Feb 16 2015, 7:14 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7285: Phortune can fatal on Subscription View page with bad query

Commits

Restricted Diffusion Commit
rP5a9d70707b9e: Fix bad Phortune Subscriptions query

Summary

Fixes T7285. If the user tries to view a subscription they don't have permission to view, we may filter all the subscriptions out, then still try to load related data. This can fatal because it's invalid.

Instead, bail if we filtered everything.

Test Plan

Subscritption detail page of another user's subscription is now 404 instead of fatal.

Diff Detail

Repository

rP Phabricator

Branch

subquery

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4510
Build 4524: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28395.Feb 16 2015, 7:14 PM

epriestley retitled this revision from to Fix bad Phortune Subscriptions query.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T7285: Phortune can fatal on Subscription View page with bad query.

Herald added a subscriber: epriestley. · View Herald TranscriptFeb 16 2015, 7:14 PM

chad accepted this revision.Feb 16 2015, 7:17 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 16 2015, 7:17 PM

Closed by commit rP5a9d70707b9e: Fix bad Phortune Subscriptions query (authored by epriestley, committed by epriestley). · Explain WhyFeb 16 2015, 7:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phortune/

query/

PhortuneSubscriptionQuery.php

12 lines

Diff 28395

View Options

src/applications/phortune/query/PhortuneSubscriptionQuery.php

Fix bad Phortune Subscriptions queryClosedPublicActions