Page MenuHomePhabricator

Fix bad Phortune Subscriptions query
ClosedPublic

Authored by epriestley on Feb 16 2015, 7:14 PM.
Tags
None
Referenced Files
F14372779: D11780.diff
Fri, Dec 20, 8:09 PM
F14370207: D11780.diff
Fri, Dec 20, 5:40 PM
Unknown Object (File)
Tue, Dec 10, 5:34 PM
Unknown Object (File)
Fri, Dec 6, 11:30 AM
Unknown Object (File)
Thu, Nov 28, 11:08 AM
Unknown Object (File)
Wed, Nov 27, 4:26 PM
Unknown Object (File)
Nov 19 2024, 2:10 PM
Unknown Object (File)
Oct 23 2024, 6:09 PM
Subscribers

Details

Summary

Fixes T7285. If the user tries to view a subscription they don't have permission to view, we may filter all the subscriptions out, then still try to load related data. This can fatal because it's invalid.

Instead, bail if we filtered everything.

Test Plan

Subscritption detail page of another user's subscription is now 404 instead of fatal.

Diff Detail

Repository
rP Phabricator
Branch
subquery
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4510
Build 4524: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix bad Phortune Subscriptions query.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 16 2015, 7:17 PM
This revision was automatically updated to reflect the committed changes.