Page MenuHomePhabricator

Correct `notification.pid` to `notification.pidfile`
ClosedPublic

Authored by eliaspro on Feb 14 2015, 7:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 20, 8:40 PM
Unknown Object (File)
Wed, Nov 16, 1:32 AM
Unknown Object (File)
Tue, Nov 15, 11:57 PM
Unknown Object (File)
Sat, Nov 12, 7:15 PM
Unknown Object (File)
Fri, Nov 11, 6:16 PM
Unknown Object (File)
Wed, Nov 9, 8:32 AM
Unknown Object (File)
Wed, Nov 9, 8:32 AM
Unknown Object (File)
Wed, Nov 9, 8:32 AM
Subscribers

Details

Summary

The correct conf variable is notification.pidfile, not notification.pid.
See also:

  • src/applications/config/option/PhabricatorNotificationConfigOptions.php:58
  • src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php:34
Test Plan

Grepped the whole source of Phabricator for occurences of notification.pid,
but all matches pointed to notification.pidfile instead.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

eliaspro retitled this revision from to Correct `notification.pid` to `notification.pidfile`.
eliaspro updated this object.
eliaspro edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Feb 14 2015, 10:32 PM
This revision was automatically updated to reflect the committed changes.