Correct `notification.pid` to `notification.pidfile`
ClosedPublic
Actions

Authored by eliaspro on Feb 14 2015, 7:31 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPa8cc1c05e528: Correct `notification.pid` to `notification.pidfile`

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

The correct conf variable is notification.pidfile, not notification.pid.
See also:

src/applications/config/option/PhabricatorNotificationConfigOptions.php:58
src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php:34

Test Plan

Grepped the whole source of Phabricator for occurences of notification.pid,
but all matches pointed to notification.pidfile instead.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

eliaspro updated this revision to Diff 28374.Feb 14 2015, 7:31 PM

eliaspro retitled this revision from to Correct `notification.pid` to `notification.pidfile`.

eliaspro updated this object.

eliaspro edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 14 2015, 7:31 PM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added a subscriber: epriestley. · View Herald Transcript

Thanks!

This revision is now accepted and ready to land.Feb 14 2015, 10:32 PM

Closed by commit rPa8cc1c05e528: Correct `notification.pid` to `notification.pidfile` (authored by eliaspro, committed by epriestley). · Explain WhyFeb 14 2015, 10:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

docs/

user/

configuration/

notifications.diviner

2 lines

Diff 28376

View Options

src/docs/user/configuration/notifications.diviner

Correct `notification.pid` to `notification.pidfile`ClosedPublicActions