losen pep8 version check
ClosedPublic
Actions

Authored by cburroughs on Feb 10 2015, 3:23 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7224: pep8 version check fails on two digit versions

Commits

rARC6dadb6b48c9f: losen pep8 version check

Summary

pep8 has used both 2 (1.2) and 3 (1.2.1) digit versions. Losen
the version check to allow for both.

NOTE: This is the same regex as flake8.

Test Plan

arc unit with a 2 and 3 digit pep8 version on $PATH.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cburroughs updated this revision to Diff 28243.Feb 10 2015, 3:23 AM

cburroughs retitled this revision from to losen pep8 version check.

cburroughs updated this object.

cburroughs edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 10 2015, 3:23 AM

Herald added a subscriber: epriestley. · View Herald Transcript

joshuaspence added a subscriber: joshuaspence.Feb 10 2015, 7:27 AM

epriestley accepted this revision.Feb 10 2015, 2:17 PM

epriestley added a reviewer: epriestley.

This revision is now accepted and ready to land.Feb 10 2015, 2:17 PM

Closed by commit rARC6dadb6b48c9f: losen pep8 version check (authored by cburroughs, committed by epriestley). · Explain WhyFeb 10 2015, 2:17 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence added a task: T7224: pep8 version check fails on two digit versions.Feb 11 2015, 12:07 PM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistPEP8Linter.php

2 lines

Diff 28261

View Options

src/lint/linter/ArcanistPEP8Linter.php

losen pep8 version checkClosedPublicActions