Page MenuHomePhabricator

Fix lookup of commits in Subversion
ClosedPublic

Authored by epriestley on Feb 3 2015, 1:57 PM.

Details

Summary

Fixes T7122. The way this query works is a little surprising:

  • If executed as withRepositoryIDs(...), it assumes you are passing one or more repository IDs, so it will never resolve ambiguous identifiers (e.g., "123" instead of "rSVN123").
  • If executed as withRepository(...), it knows you are passing exactly one repository and will use that to imply context and resolve these identifiers correctly.

This isn't very obvious from the API, but I'm not sure how to make it more clear.

(Making withRepositoryIDs() do the withRepository(...) thing if only one ID was passed in would mean its behavior varied if you passed 1 vs 2 repository IDs, which seems worse / morse surprising.)

Test Plan

Various subversion UIs no longer fail to look up commits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix lookup of commits in Subversion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.

Yep, this seems to fix the problem for me here. Thanks.

btrahan edited edge metadata.
This revision is now accepted and ready to land.Feb 3 2015, 5:50 PM
This revision was automatically updated to reflect the committed changes.