Differential D11630

Policy - clean up access to user profile image uri
ClosedPublic
Actions

Authored by btrahan on Feb 2 2015, 9:56 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T7094: Clean up T603

Commits

Restricted Diffusion Commit
rPb2320c2e6817: Policy - clean up access to user profile image uri

Summary

Ref T7094. We already had and were mostly using "needProfileImage" on the people query class. Only real trick in this diff is deleting a conduit end point that has been marked deprecated for the better part of 3 years.

Test Plan

clicked around the people action and profiles and calendars loaded nicely.

Diff Detail

Repository

rP Phabricator

Branch

T7094_8

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 4255
Build 4268: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 27987.Feb 2 2015, 9:56 PM

btrahan added a task: T7094: Clean up T603.

btrahan retitled this revision from to Policy - clean up access to user profile image uri.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 2 2015, 9:56 PM

Let me see if I can dust off D6333 too.

This revision is now accepted and ready to land.Feb 2 2015, 9:58 PM

epriestley mentioned this in D11631: Policy - clean up access to user profile image uri.Feb 2 2015, 9:59 PM

includes bonus bug fix for missing $for_app = false declaration... (duplicate D11631 happened as I didn't kill arc diff fast enough when I saw an error about that on my console)