Fix dialog z-index issue
ClosedPublic
Actions

Authored by epriestley on Jan 29 2015, 2:56 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7081: "Mark all notifications as read" dialog is behind overlay on iOS

Commits

Restricted Diffusion Commit
rP31c64b6772da: Fix dialog z-index issue

Summary

Fixes T7081. History here:

JX.Scrollbar made the page scroll weird when a dialog came up because it was half-frame and half-document.
I made it fully frame-level.
But this wasn't really right; a better fix is to make it fully document-level.

Test Plan

Weird scroll on opening dialog is still fixed.
iOS Safari no longer puts the mask over the dialog.

Diff Detail

Repository

rP Phabricator

Branch

dscroll

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4153
Build 4166: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27813.Jan 29 2015, 2:56 PM

epriestley retitled this revision from to Fix dialog z-index issue.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T7081: "Mark all notifications as read" dialog is behind overlay on iOS.

Herald added a subscriber: epriestley. · View Herald TranscriptJan 29 2015, 2:56 PM

chad accepted this revision.Jan 29 2015, 3:09 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 29 2015, 3:09 PM

Closed by commit rP31c64b6772da: Fix dialog z-index issue (authored by epriestley, committed by epriestley). · Explain WhyJan 29 2015, 3:10 PM

This revision was automatically updated to reflect the committed changes.

btrahan awarded a token.Jan 29 2015, 5:04 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

28 lines

webroot/

rsrc/

externals/

javelin/

lib/

Workflow.js

16 lines

Diff 27813

View Options

resources/celerity/map.php