Page MenuHomePhabricator

Regenerate Quickstart SQL
ClosedPublic

Authored by epriestley on Jan 21 2015, 12:34 AM.

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP614f911217cf: Regenerate Quickstart SQL
Summary

One advantage I wanted to get out of T1191 is automated rebuilds of quickstart.sql. If they don't actually work, I'd like to know sooner rather than later. We haven't rebuilt in a couple months, so give it a shot.

Ran into two issues:

  • Some very old patches specify overlong keys which don't work if your default charsets are utf8mb4. Shorten these. No real users have applied these in a very long time.
  • Some gymnastics around corpus for the new Conpherence search index.
Test Plan
  • Ran arc unit --everything, got clean results.
  • Cost to do a storage upgrade on an empty namespace dropped from ~4s to ~3s.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Regenerate Quickstart SQL.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.

The actual diff is reasonably human-reviewable, even!

btrahan edited edge metadata.

Great success!

This revision is now accepted and ready to land.Jan 21 2015, 12:37 AM
This revision was automatically updated to reflect the committed changes.