Page MenuHomePhabricator
Differential D11388

Fix access to undeclared variable when trying to create invalid Auth provider
ClosedPublic
Actions

Authored by epriestley on Jan 14 2015, 2:23 PM.
Tags
None
Referenced Files
F14867556: D11388.id27349.diff
Sat, Feb 8, 1:10 AM
F14867555: D11388.id27348.diff
Sat, Feb 8, 1:10 AM
F14867554: D11388.id.diff
Sat, Feb 8, 1:10 AM
F14867553: D11388.diff
Sat, Feb 8, 1:10 AM
Unknown Object (File)
Tue, Feb 4, 1:50 AM
Unknown Object (File)
Thu, Jan 30, 2:47 PM
Unknown Object (File)
Mon, Jan 27, 8:16 AM
Unknown Object (File)
Sat, Jan 25, 10:09 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T6971: Unhandled Exception ("RuntimeException") – Undefined variable: provider
Commits
Restricted Diffusion Commit
rP39406bd1f3a4: Fix access to undeclared variable when trying to create invalid Auth provider
Summary

Ref T6971. This fixes the error the user reported. Not sure what's up with the root cause of their issue.

Test Plan

Went to /auth/config/new/asdfqwer/ and got a 404 instead of an exception.

Diff Detail

Repository
rP Phabricator
Branch
provtype
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3838
Build 3850: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 27348.Jan 14 2015, 2:23 PM
epriestley retitled this revision from to Fix access to undeclared variable when trying to create invalid Auth provider.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T6971: Unhandled Exception ("RuntimeException") – Undefined variable: provider.
Herald added a subscriber: epriestley. · View Herald TranscriptJan 14 2015, 2:23 PM
epriestley added inline comments.Jan 14 2015, 2:24 PM
src/applications/auth/controller/config/PhabricatorAuthEditController.php
44

Specifically, we'd hit an exception on this line after failing to match a candidate.

chad accepted this revision.Jan 14 2015, 2:50 PM
chad added a reviewer: chad.
This revision is now accepted and ready to land.Jan 14 2015, 2:50 PM
Closed by commit rP39406bd1f3a4: Fix access to undeclared variable when trying to create invalid Auth provider (authored by epriestley, committed by epriestley). · Explain WhyJan 14 2015, 2:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
controller/
config/
2 lines

Diff 27348

View Options

src/applications/auth/controller/config/PhabricatorAuthEditController.php

Loading...
Phabricator · Built by Phacility