Page MenuHomePhabricator

Change the default value for `ArcanistExternalLinter::shouldExpectCommandErrors`
ClosedPublic

Authored by joshuaspence on Jan 11 2015, 9:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 6:28 AM
Unknown Object (File)
Fri, Nov 22, 8:54 PM
Unknown Object (File)
Wed, Nov 20, 1:51 AM
Unknown Object (File)
Fri, Nov 15, 7:50 PM
Unknown Object (File)
Tue, Nov 12, 8:32 AM
Unknown Object (File)
Fri, Nov 8, 8:38 AM
Unknown Object (File)
Thu, Nov 7, 7:06 PM
Unknown Object (File)
Thu, Nov 7, 7:04 PM
Subscribers

Details

Summary

It is more common for linters to exit with a non-zero status than it is for linters to return with a zero exit status, Really this function serves very little purposes, it simply determines whether or not to throw an exception if a non-zero status is returned by the external linter.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3751
Build 3762: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Change the default value for `ArcanistExternalLinter::shouldExpectCommandErrors`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

We can delete like 50 subclass implementations, right?

This revision now requires changes to proceed.Jan 11 2015, 4:59 PM
joshuaspence edited edge metadata.

Remove implementation from subclasses

epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 11 2015, 7:57 PM
This revision was automatically updated to reflect the committed changes.