Page MenuHomePhabricator

Add Videos to Remarkup
ClosedPublic

Authored by epriestley on Jan 9 2015, 5:00 PM.
Referenced Files
Unknown Object (File)
Thu, Nov 17, 2:24 PM
Unknown Object (File)
Tue, Nov 15, 5:28 PM
Unknown Object (File)
Tue, Nov 15, 5:28 PM
Unknown Object (File)
Tue, Nov 15, 4:51 PM
Unknown Object (File)
Tue, Nov 15, 6:55 AM
Unknown Object (File)
Mon, Nov 14, 10:15 AM
Unknown Object (File)
Fri, Nov 11, 9:27 PM
Unknown Object (File)
Wed, Nov 9, 11:12 PM

Details

Summary

Ref T6916. Added video to remarkup using D7156 as reference.

Test Plan
  • Viewed video files (MP4, Ogg) in Safari, Chrome, Firefox (some don't work, e.g., OGG in Safari, but nothing we can really do about that).
  • Used alt.
  • Used autoplay.
  • Used loop.
  • Used media=audio.
  • Viewed file detail page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nateguchi2 retitled this revision from to Add Videos to Remarkup.
nateguchi2 updated this object.
nateguchi2 edited the test plan for this revision. (Show Details)
nateguchi2 added a reviewer: epriestley.
nateguchi2 set the repository for this revision to rP Phabricator.
nateguchi2 added a project: Remarkup.
nateguchi2 changed the visibility from "Public (No Login Required)" to "All Users".
epriestley edited reviewers, added: nateguchi2; removed: epriestley.
epriestley edited edge metadata.
  • Handle maybe-audio, maybe-video files (like "application/ogg").
  • Clean up display of file properties in Files ("Image", "Audio", "Video", etc) a little.
  • Add media for media="audio", to explicitly render ambiguous files as audio.
  • Clean up and document attributes.
epriestley edited edge metadata.
  • Remove debugging code for file mime types.
epriestley edited the test plan for this revision. (Show Details)
epriestley edited edge metadata.

That Test Plan prose diff went very interestingly.

asherkin changed the visibility from "All Users" to "Public (No Login Required)".Jun 7 2016, 6:25 PM

The diff should be a bit more reasonable now:

Screen Shot 2016-06-07 at 1.04.41 PM.png (371×631 px, 39 KB)

chad edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2016, 8:19 PM
This revision was automatically updated to reflect the committed changes.