Differential D11276

Make properties in the `PhutilUnitTestEngineTestCase` class private
ClosedPublic
Actions

Authored by joshuaspence on Jan 8 2015, 8:02 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC4e38fac47d99: Make properties in the `PhutilUnitTestEngineTestCase` class private

Summary

There's no need for these properties to be (implicitly) public.

Test Plan

N/A

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3677
Build 3687: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27089.Jan 8 2015, 8:02 AM

joshuaspence retitled this revision from to Make properties in the `PhutilUnitTestEngineTestCase` class private.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 8 2015, 8:02 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 8 2015, 8:07 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 8 2015, 8:07 AM

Closed by commit rARC4e38fac47d99: Make properties in the `PhutilUnitTestEngineTestCase` class private (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 8 2015, 11:44 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

unit/

engine/

__tests__/

PhutilUnitTestEngineTestCase.php

8 lines

Diff 27089

View Options

src/unit/engine/tests/PhutilUnitTestEngineTestCase.php

Make properties in the `PhutilUnitTestEngineTestCase` class privateClosedPublicActions