Page MenuHomePhabricator
Differential D11256

Normalize 'Archived' states in object headers
ClosedPublic
Actions

Authored by chad on Jan 6 2015, 7:01 PM.
Tags
None
Referenced Files
F13231110: D11256.diff
Tue, May 21, 12:12 AM
F13210405: D11256.diff
Fri, May 17, 4:48 AM
F13195861: D11256.diff
Sun, May 12, 10:41 PM
Unknown Object (File)
Fri, May 3, 2:21 AM
Unknown Object (File)
Mon, Apr 29, 1:47 PM
Unknown Object (File)
Wed, Apr 24, 9:56 PM
Unknown Object (File)
Apr 21 2024, 3:53 PM
Unknown Object (File)
Apr 17 2024, 2:55 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP3e421c74503c: Normalize 'Archived' states in object headers
Summary

Quick pass at cleaning up language, icons, colors for 'Archive' and 'Activate' on various objects.

Test Plan

Tested archiving and activating each object changed.

pasted_file (259×336 px, 41 KB)

pasted_file (328×373 px, 40 KB)

Diff Detail

Repository
rP Phabricator
Branch
red-archived
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3640
Build 3649: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 27016.Jan 6 2015, 7:01 PM
chad retitled this revision from to Normalize 'Archived' states in object headers.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJan 6 2015, 7:01 PM
chad edited the test plan for this revision. (Show Details)Jan 6 2015, 7:02 PM
epriestley accepted this revision.Jan 6 2015, 7:03 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2015, 7:03 PM
chad edited the test plan for this revision. (Show Details)Jan 6 2015, 7:03 PM
chad edited edge metadata.

I should probably make an icon constant somewhere, so OPEN, CLOSED, DELETE, etc all are defined in one place.

Closed by commit rP3e421c74503c: Normalize 'Archived' states in object headers (authored by chad, committed by chad). · Explain WhyJan 6 2015, 7:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27016

View Options

src/applications/dashboard/controller/PhabricatorDashboardPanelViewController.php

Loading...
View Options

src/applications/herald/controller/HeraldDisableController.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleViewController.php

Loading...
View Options

src/applications/herald/storage/HeraldRuleTransaction.php

Loading...
View Options

src/applications/macro/controller/PhabricatorMacroViewController.php

Loading...
View Options

src/applications/ponder/controller/PonderQuestionViewController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectArchiveController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectEditMainController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...
Phabricator · Built by Phacility