Page MenuHomePhabricator
Differential D11146

remove unused FeedStory object in getTitleForFeed functions
ClosedPublic
Actions

Authored by fabe on Jan 2 2015, 1:17 PM.
Tags
None
Referenced Files
F14383122: D11146.diff
Sat, Dec 21, 6:45 AM
Unknown Object (File)
Tue, Dec 17, 7:19 AM
Unknown Object (File)
Tue, Dec 10, 7:03 PM
Unknown Object (File)
Thu, Dec 5, 7:58 AM
Unknown Object (File)
Tue, Dec 3, 5:06 AM
Unknown Object (File)
Sat, Nov 23, 3:00 PM
Unknown Object (File)
Sat, Nov 23, 3:00 PM
Unknown Object (File)
Sat, Nov 23, 2:49 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6545: Show unified config edit log in Config web UI
Commits
Restricted Diffusion Commit
rP00495e3a0e2e: remove unused FeedStory object in getTitleForFeed functions
Summary

Removes an unused PhabricatorFeedStory Parameter from all getTitleForFeed() and getApplicationTransactionTitleForFeed() functions.
Ref D11088 Ref T6545

Test Plan

ran all unit tests and viewed some dashboard feeds

Diff Detail

Repository
rP Phabricator
Branch
removestory
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3482
Build 3489: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

fabe updated this revision to Diff 26758.Jan 2 2015, 1:17 PM
fabe retitled this revision from to remove unused FeedStory object in getTitleForFeed functions.
fabe updated this object.
fabe edited the test plan for this revision. (Show Details)
fabe added a reviewer: epriestley.
fabe added a task: T6545: Show unified config edit log in Config web UI.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 2 2015, 1:17 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 2 2015, 4:45 PM
epriestley edited edge metadata.

Thanks!

This revision is now accepted and ready to land.Jan 2 2015, 4:45 PM
Closed by commit rP00495e3a0e2e: remove unused FeedStory object in getTitleForFeed functions (authored by fabe, committed by epriestley). · Explain WhyJan 2 2015, 4:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 26758

View Options

src/applications/audit/storage/PhabricatorAuditTransaction.php

Loading...
View Options

src/applications/config/storage/PhabricatorConfigTransaction.php

Loading...
View Options

src/applications/dashboard/storage/PhabricatorDashboardPanelTransaction.php

Loading...
View Options

src/applications/dashboard/storage/PhabricatorDashboardTransaction.php

Loading...
View Options

src/applications/differential/customfield/DifferentialBlameRevisionField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialRepositoryField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialRevertPlanField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialSummaryField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialTestPlanField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialTitleField.php

Loading...
View Options

src/applications/differential/storage/DifferentialTransaction.php

Loading...
View Options

src/applications/fund/storage/FundInitiativeTransaction.php

Loading...
View Options

src/applications/macro/storage/PhabricatorMacroTransaction.php

Loading...
View Options

src/applications/maniphest/storage/ManiphestTransaction.php

Loading...
View Options

src/applications/paste/storage/PhabricatorPasteTransaction.php

Loading...
View Options

src/applications/pholio/storage/PholioTransaction.php

Loading...
View Options

src/applications/phriction/storage/PhrictionTransaction.php

Loading...
View Options

src/applications/ponder/storage/PonderAnswerTransaction.php

Loading...
View Options

src/applications/ponder/storage/PonderQuestionTransaction.php

Loading...
View Options

src/applications/releeph/storage/ReleephProductTransaction.php

Loading...
View Options

src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
View Options

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php

Loading...
Phabricator · Built by Phacility