Paths

Table of Contentst

Differential D11079

Use `new FutureIterator` instead of `Futures`
ClosedPublic
Actions

Authored by joshuaspence on Dec 30 2014, 12:10 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6829: The `Futures()` function violates naming conventions

Commits

rARC721bdf424bf3: Use `new FutureIterator` instead of `Futures`

Summary

Ref T6829. Deprecate the Futures() function.

Test Plan

N/A

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26593.Dec 30 2014, 12:10 PM

joshuaspence retitled this revision from to Use `new FutureIterator` instead of `Futures`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T6829: The `Futures()` function violates naming conventions.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 30 2014, 12:10 PM

Herald added subscribers: epriestley, Korvin, aurelijus. · View Herald Transcript

epriestley accepted this revision.Dec 30 2014, 12:13 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 30 2014, 12:13 PM

Closed by commit rARC721bdf424bf3: Use `new FutureIterator` instead of `Futures` (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 30 2014, 12:18 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D11081: Remove the `Futures()` method.Dec 30 2014, 12:21 PM

joshuaspence mentioned this in rPHU9319f6d50d52: Remove the `Futures()` method.Dec 30 2014, 12:39 PM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistCSharpLinter.php

4 lines

ArcanistFutureLinter.php

2 lines

ArcanistScriptAndRegexLinter.php

4 lines

repository/

api/

ArcanistGitAPI.php

2 lines

ArcanistMercurialAPI.php

4 lines

unit/

engine/

NoseTestEngine.php

4 lines

PhpunitTestEngine.php

4 lines

XUnitTestEngine.php

6 lines

workflow/

ArcanistDiffWorkflow.php

17 lines

ArcanistFeatureWorkflow.php

6 lines

ArcanistGitHookPreReceiveWorkflow.php

3 lines

Diff 26595

View Options

src/lint/linter/ArcanistCSharpLinter.php

View Options

src/lint/linter/ArcanistFutureLinter.php

View Options

src/lint/linter/ArcanistScriptAndRegexLinter.php

View Options

src/repository/api/ArcanistGitAPI.php

View Options

src/repository/api/ArcanistMercurialAPI.php

View Options

src/unit/engine/NoseTestEngine.php

View Options

src/unit/engine/PhpunitTestEngine.php

View Options

src/unit/engine/XUnitTestEngine.php

View Options

src/workflow/ArcanistDiffWorkflow.php

View Options

src/workflow/ArcanistFeatureWorkflow.php

View Options

src/workflow/ArcanistGitHookPreReceiveWorkflow.php

Use `new FutureIterator` instead of `Futures`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26595

src/lint/linter/ArcanistCSharpLinter.php

src/lint/linter/ArcanistFutureLinter.php

src/lint/linter/ArcanistScriptAndRegexLinter.php

src/repository/api/ArcanistGitAPI.php

src/repository/api/ArcanistMercurialAPI.php

src/unit/engine/NoseTestEngine.php

src/unit/engine/PhpunitTestEngine.php

src/unit/engine/XUnitTestEngine.php

src/workflow/ArcanistDiffWorkflow.php

src/workflow/ArcanistFeatureWorkflow.php

src/workflow/ArcanistGitHookPreReceiveWorkflow.php

Use `new FutureIterator` instead of `Futures`
ClosedPublic
Actions

Revision Contents
Changeset List