Differential D10911

Differential - fix bug destroying diffs
ClosedPublic
Actions

Authored by btrahan on Dec 1 2014, 8:12 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T6659: Error when using `bin/remove destroy` on a Diff

Commits

Restricted Diffusion Commit
rP1716861ad8ee: Differential - fix bug destroying diffs

Summary

I think this was a "hacked" sub thing that never got updated when we switched to a real editor? I am not 100% sure how these methods are used, so please let me know if I should expand my test plan. Fixes T6659.

Test Plan

made a diff from the web ui, looked up the phid from mysql, ran bin/remove destroy <phid>, and it worked!

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 26208.Dec 1 2014, 8:12 PM

btrahan added a task: T6659: Error when using `bin/remove destroy` on a Diff.

btrahan retitled this revision from to Differential - fix bug destroying diffs.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 1 2014, 8:12 PM

Harbormaster completed remote builds in B3154: Diff 26208.Dec 1 2014, 8:13 PM

Yep, these look correct to me. I think the test plan is sufficient.

This revision is now accepted and ready to land.Dec 1 2014, 8:29 PM

Closed by commit rP1716861ad8ee: Differential - fix bug destroying diffs (authored by btrahan, committed by btrahan). · Explain WhyDec 1 2014, 10:46 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T8650: DifferentialTransactionEditor may race HarbormasterBuildWorker.Jun 25 2015, 4:50 PM

epriestley mentioned this in D17139: Allow Harbormaster builds to publish to a different object.Jan 4 2017, 9:24 PM

epriestley mentioned this in rPef05bf335d8e: Allow Harbormaster builds to publish to a different object.Jan 4 2017, 9:46 PM

epriestley mentioned this in T9276: Display when builds happen with status somewhere handy, like the differential timeline.Jan 4 2017, 9:56 PM

epriestley mentioned this in D19920: Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface.Dec 20 2018, 6:43 PM

epriestley mentioned this in rP11cf8f05b176: Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface.Dec 20 2018, 11:16 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialDiff.php

16 lines

Diff 26215

View Options

src/applications/differential/storage/DifferentialDiff.php

Differential - fix bug destroying diffsClosedPublicActions