Page MenuHomePhabricator
Differential D10870

Associate Harbormaster build target with leases
ClosedPublic
Actions

Authored by hach-que on Nov 18 2014, 11:29 PM.
Tags
None
Referenced Files
F14353181: D10870.id33744.diff
Thu, Dec 19, 4:26 PM
F14353180: D10870.id26106.diff
Thu, Dec 19, 4:26 PM
F14353179: D10870.id.diff
Thu, Dec 19, 4:26 PM
F14353178: D10870.diff
Thu, Dec 19, 4:26 PM
Unknown Object (File)
Wed, Dec 18, 12:11 AM
Unknown Object (File)
Thu, Dec 12, 1:48 AM
Unknown Object (File)
Tue, Dec 10, 7:31 AM
Unknown Object (File)
Sat, Dec 7, 4:50 PM
View All Files
Subscribers
epriestley
joshuaspence
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T1049: Implement Harbormaster
Commits
Restricted Diffusion Commit
rP254b394f2c2b: Associate Harbormaster build target with leases
Summary

Ref T1049. This ensures the Harbormaster build target is associated with leases, so in the future we can query things and find out whether builds are still running with associated leases.

Test Plan

Leased a host, checked the DB and saw the field populated.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

hach-que updated this revision to Diff 26106.Nov 18 2014, 11:29 PM
hach-que retitled this revision from to Associate Harbormaster build target with leases.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 18 2014, 11:29 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
hach-que updated this object.Nov 18 2014, 11:29 PM
hach-que edited edge metadata.
hach-que added a task: T1049: Implement Harbormaster.
Harbormaster completed remote builds in B3084: Diff 26106.Nov 18 2014, 11:29 PM
joshuaspence added a subscriber: joshuaspence.Feb 25 2015, 7:31 AM
epriestley accepted this revision.Aug 8 2015, 6:25 PM
epriestley edited edge metadata.

Seems like nothing actually calls setOwnerPHID() or getOwnerPHID() or accesses ownerPHID, but this usage seems reasonable to me.

This revision is now accepted and ready to land.Aug 8 2015, 6:25 PM
Closed by commit rP254b394f2c2b: Associate Harbormaster build target with leases (authored by hach-que, committed by hach-que). · Explain WhyAug 24 2015, 7:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
step/
1 line

Diff 33744

View Options

src/applications/harbormaster/step/HarbormasterLeaseHostBuildStepImplementation.php

Loading...
Phabricator · Built by Phacility