Page MenuHomePhabricator

Associate Harbormaster build target with leases
ClosedPublic

Authored by hach-que on Nov 18 2014, 11:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 8:03 AM
Unknown Object (File)
Tue, Mar 26, 8:03 AM
Unknown Object (File)
Tue, Mar 26, 8:03 AM
Unknown Object (File)
Sat, Mar 16, 7:26 PM
Unknown Object (File)
Feb 25 2024, 2:16 AM
Unknown Object (File)
Feb 8 2024, 5:51 AM
Unknown Object (File)
Feb 7 2024, 5:48 AM
Unknown Object (File)
Jan 26 2024, 10:27 AM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T1049: Implement Harbormaster
Commits
Restricted Diffusion Commit
rP254b394f2c2b: Associate Harbormaster build target with leases
Summary

Ref T1049. This ensures the Harbormaster build target is associated with leases, so in the future we can query things and find out whether builds are still running with associated leases.

Test Plan

Leased a host, checked the DB and saw the field populated.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

hach-que retitled this revision from to Associate Harbormaster build target with leases.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
epriestley edited edge metadata.

Seems like nothing actually calls setOwnerPHID() or getOwnerPHID() or accesses ownerPHID, but this usage seems reasonable to me.

This revision is now accepted and ready to land.Aug 8 2015, 6:25 PM
This revision was automatically updated to reflect the committed changes.