Differential D10768

Apply remarkup-code padding to child spans as well
ClosedPublic
Actions

Authored by chad on Oct 31 2014, 5:42 PM.

Tags

None

Referenced Files

	F17878408: D10768.id.diff
	Mon, Jul 28, 8:18 PM

	F17856874: D10768.diff
	Sun, Jul 27, 5:48 PM

	Unknown Object (File)
	Jun 27 2025, 10:11 AM

	Unknown Object (File)
	Jun 26 2025, 11:51 AM

	Unknown Object (File)
	Jun 5 2025, 5:26 PM

	Unknown Object (File)
	May 26 2025, 8:58 PM

	Unknown Object (File)
	May 24 2025, 5:03 PM

	Unknown Object (File)
	May 20 2025, 7:37 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T6440: Green background on syntax highlighted code for char-level changes has weird padding

Commits

Restricted Diffusion Commit
rP53493ccf9396: Apple remarkup-code padding to child spans as well.

Summary

Fixes T6440. The issue is when a nested span appears, we don't apply the spacing.

Test Plan

Test a new diff in my sandbox that exhibits the issue. Ensure spacing now aligns.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 25846.Oct 31 2014, 5:42 PM

chad retitled this revision from to Apple remarkup-code padding to child spans as well..

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T6440: Green background on syntax highlighted code for char-level changes has weird padding.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 31 2014, 5:42 PM

Harbormaster completed remote builds in B2924: Diff 25846.Oct 31 2014, 5:43 PM

epriestley accepted this revision.Oct 31 2014, 5:44 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 31 2014, 5:44 PM

First time I've seen "apple" used as a verb.

Closed by commit rP53493ccf9396: Apple remarkup-code padding to child spans as well. (authored by chad, committed by chad). · Explain WhyOct 31 2014, 5:45 PM

This revision was automatically updated to reflect the committed changes.

Yeah, phat phingered.

chad retitled this revision from Apple remarkup-code padding to child spans as well. to Apply remarkup-code padding to child spans as well.Oct 31 2014, 5:47 PM

chad edited edge metadata.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

6 lines

webroot/

rsrc/

css/

core/

5 lines

Diff 25847

resources/celerity/map.php

Loading...

webroot/rsrc/css/core/syntax.css

Loading...