Differential D10766

Fix daemon task queue to respect task priority
ClosedPublic
Actions

Authored by epriestley on Oct 31 2014, 3:29 PM.

Tags

None

Referenced Files

	F14355757: D10766.diff
	Thu, Dec 19, 6:18 PM

	Unknown Object (File)
	Sat, Dec 14, 7:41 AM

	Unknown Object (File)
	Thu, Dec 12, 6:11 PM

	Unknown Object (File)
	Sun, Dec 8, 5:59 PM

	Unknown Object (File)
	Wed, Dec 4, 7:59 PM

	Unknown Object (File)
	Wed, Dec 4, 1:55 PM

	Unknown Object (File)
	Sat, Nov 30, 7:46 AM

	Unknown Object (File)
	Wed, Nov 27, 9:22 AM

Subscribers

Details

Reviewers

joshuaspence
btrahan

Commits

Restricted Diffusion Commit
rP914b8bb32cd7: Fix daemon task queue to respect task priority

Summary

Fixes an issue with T5336 / D9871. We did 99% of the work here but didn't actually turn on the priority sorting. The unit test passed by default, which didn't catch this.

Fix the unit test (it failed).
Fix the query (test now passes).
Add a "Next in Queue" element to the UI to make this kind of thing easier to spot/understand.

Test Plan

Ran unit test. Viewed "Next in Queue". Queued some tasks, flushed the queue. Web UI tracked the state sensibly.

Diff Detail

Repository

Branch

qprio

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2922
Build 2926: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 25842.Oct 31 2014, 3:29 PM

epriestley retitled this revision from to Fix daemon task queue to respect task priority.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, joshuaspence.

epriestley added a subscriber: cburroughs.

Herald added a subscriber: epriestley. · View Herald TranscriptOct 31 2014, 3:29 PM

Harbormaster completed remote builds in B2922: Diff 25842.Oct 31 2014, 3:30 PM

Screen_Shot_2014-10-31_at_8.30.15_AM.png (360×1 px, 55 KB)

btrahan accepted this revision.Oct 31 2014, 4:24 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Oct 31 2014, 4:24 PM

Closed by commit rP914b8bb32cd7: Fix daemon task queue to respect task priority (authored by epriestley, committed by epriestley). · Explain WhyOct 31 2014, 4:27 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in T6456: Daemon worker queue not working.Nov 3 2014, 8:00 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

daemon/

controller/

PhabricatorDaemonConsoleController.php

116 lines

infrastructure/

daemon/

workers/

__tests__/

PhabricatorWorkerTestCase.php

10 lines

query/

PhabricatorWorkerLeaseQuery.php

63 lines

Diff 25842

src/applications/daemon/controller/PhabricatorDaemonConsoleController.php

Loading...

src/infrastructure/daemon/workers/tests/PhabricatorWorkerTestCase.php

Loading...

src/infrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php

Loading...