Page MenuHomePhabricator
Differential D10646

Storage - fix more query errors by escaping collate_text and collate_sort
ClosedPublic
Actions

Authored by btrahan on Oct 6 2014, 10:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 3:29 PM
Unknown Object (File)
Tue, Dec 17, 8:09 PM
Unknown Object (File)
Tue, Dec 17, 1:54 PM
Unknown Object (File)
Wed, Dec 11, 11:11 PM
Unknown Object (File)
Fri, Dec 6, 1:35 PM
Unknown Object (File)
Fri, Dec 6, 2:42 AM
Unknown Object (File)
Thu, Dec 5, 5:36 PM
Unknown Object (File)
Thu, Nov 28, 5:30 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Commits
Restricted Diffusion Commit
rP0bbe3a6d2825: Storage - fix more query errors by escaping collate_text and collate_sort
Summary

second bit of https://github.com/phacility/phabricator/pull/729

Test Plan

this is a weird pull request merge

Diff Detail

Repository
rP Phabricator
Branch
storageb
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2760
Build 2764: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 25566.Oct 6 2014, 10:32 PM
btrahan retitled this revision from to Storage - fix more query errors by escaping collate_text and collate_sort.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 6 2014, 10:32 PM
Harbormaster completed remote builds in B2758: Diff 25566.Oct 6 2014, 10:33 PM
epriestley accepted this revision.Oct 6 2014, 10:35 PM
epriestley edited edge metadata.

Ideally, use something like $escaped_text = qsprintf($conn, '%T', $collate_text); and then replace with $escaped_text, since you have a $conn handy.

This revision is now accepted and ready to land.Oct 6 2014, 10:35 PM
btrahan updated this revision to Diff 25568.Oct 6 2014, 10:46 PM
btrahan edited edge metadata.

going the preferred route

Closed by commit rP0bbe3a6d2825: Storage - fix more query errors by escaping collate_text and collate_sort (authored by btrahan, committed by btrahan).Oct 6 2014, 10:46 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B2760: Diff 25568.Oct 6 2014, 10:46 PM

Revision Contents
Changeset List

PathSize
src/
infrastructure/
storage/
management/
6 lines

Diff 25568

View Options

src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php

Loading...
Phabricator · Built by Phacility