Storage - fix more query errors by escaping collate_text and collate_sort
ClosedPublic
Actions

Authored by btrahan on Oct 6 2014, 10:32 PM.

Details

Reviewers

epriestley
chad

Commits

Restricted Diffusion Commit
rP0bbe3a6d2825: Storage - fix more query errors by escaping collate_text and collate_sort

Summary

second bit of https://github.com/phacility/phabricator/pull/729

Test Plan

this is a weird pull request merge

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 25566.Oct 6 2014, 10:32 PM

btrahan retitled this revision from to Storage - fix more query errors by escaping collate_text and collate_sort.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 6 2014, 10:32 PM

Harbormaster completed remote builds in B2758: Diff 25566.Oct 6 2014, 10:33 PM

Ideally, use something like $escaped_text = qsprintf($conn, '%T', $collate_text); and then replace with $escaped_text, since you have a $conn handy.

This revision is now accepted and ready to land.Oct 6 2014, 10:35 PM

going the preferred route

Closed by commit rP0bbe3a6d2825: Storage - fix more query errors by escaping collate_text and collate_sort (authored by btrahan, committed by btrahan).Oct 6 2014, 10:46 PM

This revision was automatically updated to reflect the committed changes.

Harbormaster completed remote builds in B2760: Diff 25568.Oct 6 2014, 10:46 PM

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

storage/

management/

PhabricatorStorageManagementAPI.php

6 lines

Diff 25569

View Options

src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php

Storage - fix more query errors by escaping collate_text and collate_sortClosedPublicActions