Page MenuHomePhabricator
Differential D10632

Create new databases with appropriate collation
ClosedPublic
Actions

Authored by epriestley on Oct 3 2014, 12:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 31, 11:04 PM
Unknown Object (File)
Thu, Jan 30, 4:33 AM
Unknown Object (File)
Tue, Jan 28, 10:24 PM
Unknown Object (File)
Thu, Jan 23, 5:14 PM
Unknown Object (File)
Thu, Jan 23, 5:14 PM
Unknown Object (File)
Thu, Jan 23, 5:14 PM
Unknown Object (File)
Thu, Jan 23, 5:41 AM
Unknown Object (File)
Sat, Jan 18, 7:34 AM
View All Files
Subscribers
epriestley

Details

Reviewers
hach-que
btrahan
Maniphest Tasks
T1191: Comments are truncated at first non-base-plane character
Commits
Restricted Diffusion Commit
rP3463ce8a514f: Create new databases with appropriate collation
Summary

Ref T1191. We don't create new databases with appropriate collation yet.

Test Plan

Created a new database and saw it issue:

>>> [10] <query> CREATE DATABASE IF NOT EXISTS `phabricator2_testo` COLLATE utf8mb4_bin

Diff Detail

Repository
rP Phabricator
Branch
createdb
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2732
Build 2736: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 25528.Oct 3 2014, 12:53 PM
epriestley retitled this revision from to Create new databases with appropriate collation.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: hach-que, btrahan.
epriestley added a task: T1191: Comments are truncated at first non-base-plane character.
Herald added a subscriber: epriestley. · View Herald TranscriptOct 3 2014, 12:53 PM
Harbormaster completed remote builds in B2732: Diff 25528.Oct 3 2014, 12:54 PM
hach-que accepted this revision.Oct 3 2014, 12:57 PM
hach-que edited edge metadata.

Tested this against the Almanac diff by dropping the DB and using bin/storage upgrade --apply phabricator:db.almanac.

This revision is now accepted and ready to land.Oct 3 2014, 12:57 PM
Closed by commit rP3463ce8a514f: Create new databases with appropriate collation (authored by epriestley, committed by epriestley).Oct 3 2014, 1:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
storage/
management/
8 lines

Diff 25528

View Options

src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php

Loading...
Phabricator · Built by Phacility