Page MenuHomePhabricator

Remove the "note" database issue status
ClosedPublic

Authored by epriestley on Sep 27 2014, 11:54 PM.
Tags
None
Referenced Files
F14396962: D10594.diff
Sun, Dec 22, 9:07 AM
Unknown Object (File)
Fri, Dec 20, 11:07 PM
Unknown Object (File)
Thu, Dec 5, 10:23 AM
Unknown Object (File)
Fri, Nov 29, 10:37 AM
Unknown Object (File)
Fri, Nov 22, 10:39 PM
Unknown Object (File)
Nov 20 2024, 1:39 PM
Unknown Object (File)
Nov 16 2024, 9:52 AM
Unknown Object (File)
Nov 12 2024, 6:22 AM
Subscribers

Details

Summary

Ref T1191. This was useful for annotating everything but we no longer need it; there are just two types of issues now:

  • Error: stuff we can't fix (missing or surplus tables/database/columns, bad column nullability).
  • Warning: stuff we can fix (column types, character sets, collations, missing or surplus keys, incorrectly defined keys, bad key uniqueness).
Test Plan

Saw 3,399 warnings and 0 errors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Remove the "note" database issue status.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 30 2014, 4:54 PM
This revision was automatically updated to reflect the committed changes.