Page MenuHomePhabricator
Differential D10523

Remove SlowvoteComment and storage
ClosedPublic
Actions

Authored by epriestley on Sep 18 2014, 9:54 PM.
Tags
None
Referenced Files
F13342921: D10523.diff
Thu, Jun 20, 6:58 PM
F13339164: D10523.id.diff
Wed, Jun 19, 3:18 PM
F13339162: D10523.id25292.diff
Wed, Jun 19, 3:18 PM
F13338956: D10523.diff
Wed, Jun 19, 1:35 PM
F13331952: D10523.diff
Mon, Jun 17, 8:19 AM
F13304765: D10523.id25292.diff
Sat, Jun 8, 12:37 PM
F13300131: D10523.diff
Fri, Jun 7, 8:51 AM
F13289284: D10523.id25287.diff
Tue, Jun 4, 11:53 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T1191: Comments are truncated at first non-base-plane character
Commits
Restricted Diffusion Commit
rPa42e4a867ebc: Remove SlowvoteComment and storage
Summary

Ref T1191. This was migrated to transactions a very long time ago.

Test Plan

Ran migration, grepped, left comments in Slowvote.

Diff Detail

Repository
rP Phabricator
Branch
utf13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2585
Build 2589: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 25287.Sep 18 2014, 9:54 PM
epriestley retitled this revision from to Remove SlowvoteComment and storage.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T1191: Comments are truncated at first non-base-plane character.
Herald added a subscriber: epriestley. · View Herald TranscriptSep 18 2014, 9:54 PM
Harbormaster completed remote builds in B2585: Diff 25287.Sep 18 2014, 9:55 PM
btrahan accepted this revision.Sep 18 2014, 10:44 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 18 2014, 10:44 PM
Closed by commit rPa42e4a867ebc: Remove SlowvoteComment and storage (authored by epriestley, committed by epriestley).Sep 19 2014, 12:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
1 line
src/
2 lines
applications/
slowvote/
storage/

Diff 25287

View Options

resources/sql/autopatches/20140918.schema.5.slowvote.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/slowvote/storage/PhabricatorSlowvoteComment.php

Loading...
Phabricator · Built by Phacility