Fix custom severity rules not being applied
ClosedPublic
Actions

Authored by joshuaspence on Sep 11 2014, 12:59 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC75ad848b9d08: Fix custom severity rules not being applied

Summary

It seems that severity.rules does not override the default linter severities set by the ArcanistLinter itself. This seems incorrect and counter-intuitive.

Test Plan

Created a "severity.rules": { "(.*)": "disabled" }" configuration and verified that it was being applied.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 25188.Sep 11 2014, 12:59 PM

joshuaspence retitled this revision from to Fix custom severity rules not being applied.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 11 2014, 12:59 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2512: Diff 25188.Sep 11 2014, 12:59 PM

epriestley accepted this revision.Sep 11 2014, 1:26 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 11 2014, 1:26 PM

Closed by commit rARC75ad848b9d08 (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistLinter.php

10 lines

Diff 25195

View Options

src/lint/linter/ArcanistLinter.php

Fix custom severity rules not being appliedClosedPublicActions