Flag - fix purple flag
ClosedPublic
Actions

Authored by btrahan on Aug 29 2014, 6:32 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Aug 25, 9:51 PM

	Unknown Object (File)
	Mon, Aug 19, 9:37 AM

	Unknown Object (File)
	Fri, Aug 16, 11:57 PM

	Unknown Object (File)
	Fri, Aug 16, 10:20 AM

	Unknown Object (File)
	Thu, Aug 15, 3:36 PM

	Unknown Object (File)
	Thu, Aug 15, 3:32 PM

	Unknown Object (File)
	Aug 5 2024, 1:20 PM

	Unknown Object (File)
	Aug 5 2024, 1:20 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley
chad

Maniphest Tasks

T5995: Remove Purple Flag - wrong icon color

Commits

Restricted Diffusion Commit
rP482784b9b22c: Flag - fix purple flag

Summary

purple != violet, and in our CSS we call these things by the fanciest of terms. Fixes T5995.

Test Plan

flagged something purple and saw that the "remove purple flag" flag was indeed purple. quickly tested other colors and they all seem good too.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 25005.Aug 29 2014, 6:32 PM

btrahan added a task: T5995: Remove Purple Flag - wrong icon color.

btrahan retitled this revision from to Flag - fix purple flag.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 29 2014, 6:32 PM

Harbormaster completed remote builds in B2393: Diff 25005.Aug 29 2014, 6:32 PM

chad accepted this revision.Aug 29 2014, 8:09 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 29 2014, 8:09 PM

Closed by commit rP482784b9b22c (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

flag/

constants/

PhabricatorFlagColor.php

2 lines

Diff 25009

View Options

src/applications/flag/constants/PhabricatorFlagColor.php

Flag - fix purple flagClosedPublicActions