Ponder - fix redirect after leaving a question comment
ClosedPublic
Actions

Authored by btrahan on Aug 29 2014, 6:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Aug 28, 2:26 PM

	Unknown Object (File)
	Mon, Aug 26, 12:33 AM

	Unknown Object (File)
	Mon, Aug 5, 3:33 PM

	Unknown Object (File)
	Mon, Aug 5, 2:22 PM

	Unknown Object (File)
	Mon, Aug 5, 2:22 PM

	Unknown Object (File)
	Mon, Aug 5, 2:21 PM

	Unknown Object (File)
	Mon, Aug 5, 1:21 PM

	Unknown Object (File)
	Mon, Aug 5, 6:06 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley
chad

Maniphest Tasks

T5992: Ponder comments don't ajax or reload page

Commits

Restricted Diffusion Commit
rP546d092ebd72: Ponder - fix redirect after leaving a question comment

Summary

we did some security lock down on URI stuff and I think this was a casualty. Fixes T5992.

Test Plan

left a comment, got redirected. no more 500 response.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 25003.Aug 29 2014, 6:27 PM

btrahan added a task: T5992: Ponder comments don't ajax or reload page.

btrahan retitled this revision from to Ponder - fix redirect after leaving a question comment.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 29 2014, 6:27 PM

Harbormaster completed remote builds in B2392: Diff 25003.Aug 29 2014, 6:28 PM

epriestley accepted this revision.Aug 29 2014, 6:28 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 29 2014, 6:28 PM

Closed by commit rP546d092ebd72 (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

ponder/

controller/

PonderQuestionCommentController.php

2 lines

Diff 25004

View Options

src/applications/ponder/controller/PonderQuestionCommentController.php

Ponder - fix redirect after leaving a question commentClosedPublicActions