Use a single newline between HTML mail sections
ClosedPublic
Actions

Authored by epriestley on Aug 25 2014, 2:34 PM.

Details

Reviewers

btrahan
chad
talshiri

Maniphest Tasks

T992: Send rich HTML mail bodies without impacting reply handling functionality

Commits

Restricted Diffusion Commit
rP7e655da977c0: Use a single newline between HTML mail sections

Summary

Ref T992. This makes HTML mail layout more consistent with text mail layout and fixes my greatest annoyance with it.

Test Plan

Used bin/mail list-outbound --id <id> --dump-html to view mail in Safari, saw it have a normal amount of whitespace between sections.

Diff Detail

Repository

rP Phabricator

Branch

twobr

Lint

Lint OK

Unit

Unit Tests OK

Build Status

Buildable 2339
Build 2343: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24903.Aug 25 2014, 2:34 PM

epriestley retitled this revision from to Use a single newline between HTML mail sections.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan, talshiri.

epriestley added a task: T992: Send rich HTML mail bodies without impacting reply handling functionality.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 25 2014, 2:34 PM

Harbormaster completed remote builds in B2339: Diff 24903.Aug 25 2014, 2:35 PM

chad accepted this revision.Aug 25 2014, 3:47 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 25 2014, 3:47 PM

Closed by commit rP7e655da977c0 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

view/

PhabricatorMetaMTAMailBody.php

2 lines

Diff 24903

View Options

src/applications/metamta/view/PhabricatorMetaMTAMailBody.php

Use a single newline between HTML mail sectionsClosedPublicActions