Page MenuHomePhabricator

When destroying an object, destroy its Herald transcripts too
ClosedPublic

Authored by epriestley on Aug 20 2014, 2:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 12:06 AM
Unknown Object (File)
Thu, Apr 11, 8:23 AM
Unknown Object (File)
Tue, Apr 9, 11:19 PM
Unknown Object (File)
Mar 28 2024, 12:28 AM
Unknown Object (File)
Mar 14 2024, 12:45 AM
Unknown Object (File)
Mar 14 2024, 12:45 AM
Unknown Object (File)
Mar 14 2024, 12:43 AM
Unknown Object (File)
Mar 14 2024, 12:34 AM
Subscribers

Details

Summary

Ref T5915. Make bin/remove destroy a bit more thorough, since Herald transcripts can have field information in them.

Test Plan

Used bin/remove destroy to nuke revisions, saw their transcripts vanish too.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to When destroying an object, destroy its Herald transcripts too.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 20 2014, 8:14 PM
epriestley updated this revision to Diff 24826.

Closed by commit rPe5acdd85e681 (authored by @epriestley).