Page MenuHomePhabricator

Allow Herald "diff" rules to reject content before it is written
ClosedPublic

Authored by epriestley on Aug 20 2014, 2:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 10:24 PM
Unknown Object (File)
Thu, Apr 11, 7:33 AM
Unknown Object (File)
Mar 14 2024, 12:45 AM
Unknown Object (File)
Mar 14 2024, 12:45 AM
Unknown Object (File)
Mar 14 2024, 12:43 AM
Unknown Object (File)
Mar 14 2024, 12:34 AM
Unknown Object (File)
Mar 11 2024, 10:31 AM
Unknown Object (File)
Mar 11 2024, 10:31 AM
Subscribers

Details

Summary

Fixes T5915. Occasionally, users derp up and diff private key material. Adding a pre-write Herald phase enables configuration of a partial layer of protection that will reject these changes before they hit disk, provided they can be detected by, e.g., filename.

Test Plan
  • Added a rule with checks on every field, verified they looked fine in the transcript.
  • Created some revisions to test those changes (I have a bunch of revision rules locally).
  • Verified rejects don't write transcripts to the database.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Allow Herald "diff" rules to reject content before it is written.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 20 2014, 8:16 PM
epriestley updated this revision to Diff 24824.

Closed by commit rP5ac36e8f77ee (authored by @epriestley).