Fixes T5915. Occasionally, users derp up and diff private key material. Adding a pre-write Herald phase enables configuration of a partial layer of protection that will reject these changes before they hit disk, provided they can be detected by, e.g., filename.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T5915: Allow Herald rules to reject diffs at creation time
- Commits
- Restricted Diffusion Commit
rP5ac36e8f77ee: Allow Herald "diff" rules to reject content before it is written
- Added a rule with checks on every field, verified they looked fine in the transcript.
- Created some revisions to test those changes (I have a bunch of revision rules locally).
- Verified rejects don't write transcripts to the database.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped