Differential D10271

Audit - allow queries for "partial" and "accepted" audits
ClosedPublic
Actions

Authored by btrahan on Aug 15 2014, 12:09 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T5871: Allow audit search to search for all Status values

Commits

Restricted Diffusion Commit
rP59b626d2c142: Audit - allow queries for "partial" and "accepted" audits

Summary

Fixes T5871. These queries get to use the actual column on the commit table since they are about the "aggregate" state of different audits.

Test Plan

issues queries and got sensible results.

Diff Detail

Repository

rP Phabricator

Branch

T5871

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2237
Build 2241: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 24735.Aug 15 2014, 12:09 AM

btrahan added a task: T5871: Allow audit search to search for all Status values.

btrahan retitled this revision from to Audit - allow queries for "partial" and "accepted" audits.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 15 2014, 12:09 AM

Harbormaster completed remote builds in B2237: Diff 24735.Aug 15 2014, 12:11 AM

epriestley accepted this revision.Aug 15 2014, 3:01 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 15 2014, 3:01 PM

Closed by commit rP59b626d2c142 (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

query/

PhabricatorCommitSearchEngine.php

2 lines

diffusion/

query/

DiffusionCommitQuery.php

16 lines

Diff 24735

View Options

src/applications/audit/query/PhabricatorCommitSearchEngine.php