Page MenuHomePhabricator

Fix verbose email addresses being passed to mail adapters
ClosedPublic

Authored by epriestley on Aug 12 2014, 11:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 6, 1:00 AM
Unknown Object (File)
Wed, Dec 4, 1:31 AM
Unknown Object (File)
Wed, Nov 27, 11:14 AM
Unknown Object (File)
Tue, Nov 26, 7:07 PM
Unknown Object (File)
Thu, Nov 21, 7:36 PM
Unknown Object (File)
Wed, Nov 20, 1:45 PM
Unknown Object (File)
Wed, Nov 20, 1:44 PM
Unknown Object (File)
Wed, Nov 20, 1:43 PM
Subscribers

Details

Summary

Fixes T5233.

  • The mail adapter API currently expects plain addresses (like a@b.com) in addTos(), and some adapters can not accept fancy verbose addresses (like "name" <a@b.com>).
  • When we try to send error email, we pass the entire "From" header into the API. This is incorrect.
  • Since it would be nice to make this just work in the future, fix it inside the API.
  • Specifically, this is reached with: send email -> generates error -> we try to send you an email back -> we send it to your "From" -> some mailers choke on the fancy name if you have one.
Test Plan

Processed an errorneous email with a fancy "From", got a response error.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix verbose email addresses being passed to mail adapters.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

nice one!

This revision is now accepted and ready to land.Aug 12 2014, 7:10 PM
epriestley updated this revision to Diff 24637.

Closed by commit rPe4049e879764 (authored by @epriestley).