Account for preempting events on the Phrequent list view
ClosedPublic
Actions

Authored by epriestley on Aug 11 2014, 6:58 PM.

Details

Reviewers

hach-que
btrahan

Maniphest Tasks

T5850: Phrequent list view doesn't know about preempting events

Commits

Restricted Diffusion Commit
rP0292793d4d05: Account for preempting events on the Phrequent list view

Summary

Fixes T5850. Also fixes some logic where the wrong preempting events could be attached during a bulk query.

Test Plan

Phrequent list now shows preemption-aware times.

Diff Detail

Repository

rP Phabricator

Branch

phreqlist

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2155
Build 2159: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24590.Aug 11 2014, 6:58 PM

epriestley retitled this revision from to Account for preempting events on the Phrequent list view.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: hach-que, btrahan.

epriestley added a task: T5850: Phrequent list view doesn't know about preempting events.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 11 2014, 6:58 PM

Harbormaster completed remote builds in B2155: Diff 24590.Aug 11 2014, 6:59 PM

btrahan accepted this revision.Aug 11 2014, 7:18 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Aug 11 2014, 7:18 PM

Closed by commit rP0292793d4d05 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

phrequent/

query/

PhrequentSearchEngine.php

16 lines

PhrequentUserTimeQuery.php

27 lines

Diff 24590

View Options

src/applications/phrequent/query/PhrequentSearchEngine.php