Differential D10187

T5423, "is newly created" herald rule fails on dry runs
ClosedPublic
Actions

Authored by lpriestley on Aug 7 2014, 11:59 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5423: Herald "Is newly created?" field for Maniphest Tasks fatals during dry runs

Commits

Restricted Diffusion Commit
rP7204f9fec268: T5423, "is newly created" herald rule fails on dry runs

Summary

Fixes T5423, "is newly created" herald rule fails on dry runs

Test Plan

Create herald "is newly created" rule, and do a dry run on an existing pholio mock, differential commit, or maniphest task. Should not return an exception.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

lpriestley updated this revision to Diff 24504.Aug 7 2014, 11:59 PM

lpriestley retitled this revision from to T5423, "is newly created" herald rule fails on dry runs.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T5423: Herald "Is newly created?" field for Maniphest Tasks fatals during dry runs.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 7 2014, 11:59 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2099: Diff 24504.Aug 8 2014, 12:00 AM

epriestley accepted this revision.Aug 8 2014, 12:04 AM

epriestley awarded a token.

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 8 2014, 12:04 AM

Closed by commit rP7204f9fec268 (authored by @lpriestley, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

controller/

HeraldTestConsoleController.php

2 lines

Diff 24505

View Options

src/applications/herald/controller/HeraldTestConsoleController.php

T5423, "is newly created" herald rule fails on dry runsClosedPublicActions