Page MenuHomePhabricator
Differential D10142

Add a --browse flag to `arc todo`
ClosedPublic
Actions

Authored by epriestley on Aug 4 2014, 5:39 PM.

Details

Reviewers
btrahan
csilvers
Maniphest Tasks
T5781: Moar functionality for `arc browse`!
T5787: test arc todo --browse
Commits
rARC6849e1f98a53: Add a --browse flag to `arc todo`
Summary

Ref T5781. Like D10141, but for arc todo. Fixes T5787.

Test Plan

See T5787.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24391.Aug 4 2014, 5:39 PM
epriestley retitled this revision from to Add a --browse flag to `arc todo`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, csilvers.
epriestley added tasks: T5787: test arc todo --browse, T5781: Moar functionality for `arc browse`!.
Herald added subscribers: sophiebits, epriestley. · View Herald TranscriptAug 4 2014, 5:39 PM
Harbormaster completed remote builds in B2032: Diff 24391.Aug 4 2014, 5:40 PM
csilvers accepted this revision.Aug 4 2014, 5:43 PM
csilvers edited edge metadata.

I'm not really competent to review, but seems straightforward enough to me, and it matches what you did for arc diff, so assuming that's ok I am convinced this is too. :-)

This revision is now accepted and ready to land.Aug 4 2014, 5:43 PM
epriestley closed this revision.Aug 4 2014, 7:03 PM
epriestley updated this revision to Diff 24397.

Closed by commit rARC6849e1f98a53 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
workflow/
8 lines

Diff 24397

View Options

src/workflow/ArcanistTodoWorkflow.php

Loading...
Phabricator · Built by Phacility