Page MenuHomePhabricator
Differential D10127

Apply Diffusion reply email directly with transaction editor
ClosedPublic
Actions

Authored by epriestley on Aug 2 2014, 7:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 3:46 PM
Unknown Object (File)
Wed, Apr 24, 11:43 PM
Unknown Object (File)
Sat, Apr 20, 2:23 AM
Unknown Object (File)
Fri, Apr 19, 2:06 AM
Unknown Object (File)
Fri, Apr 19, 2:06 AM
Unknown Object (File)
Fri, Apr 19, 2:05 AM
Unknown Object (File)
Sat, Apr 13, 5:20 AM
Unknown Object (File)
Thu, Apr 11, 3:28 AM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
btrahan
Maniphest Tasks
T4896: Move Audit to ApplicationTransactions
Commits
Restricted Diffusion Commit
rP25acf5d1304c: Apply Diffusion reply email directly with transaction editor
Summary

Ref T4896. Invoke the new editor directly instead of in a roundabout way when handling Audit email.

Test Plan

Used bin/mail receive-test to simulate mail, saw comment post with proper content source.

Diff Detail

Repository
rP Phabricator
Branch
audit5
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/audit/mail/PhabricatorAuditReplyHandler.php:44XHP16TODO Comment
Unit
No Test Coverage
Build Status
Buildable 2009
Build 2010: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24354.Aug 2 2014, 7:19 PM
epriestley retitled this revision from to Apply Diffusion reply email directly with transaction editor.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
epriestley added a task: T4896: Move Audit to ApplicationTransactions.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 2 2014, 7:19 PM
Harbormaster completed remote builds in B2009: Diff 24354.Aug 2 2014, 7:20 PM
btrahan accepted this revision.Aug 2 2014, 9:07 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 2 2014, 9:07 PM
epriestley closed this revision.Aug 2 2014, 9:45 PM
epriestley updated this revision to Diff 24364.

Closed by commit rP25acf5d1304c (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
mail/
32 lines

Diff 24354

View Options

src/applications/audit/mail/PhabricatorAuditReplyHandler.php

Loading...
Phabricator · Built by Phacility