Paths

Table of Contentst

Apply `diffusion.createcomment` directly with transaction editor in Audit
ClosedPublic
Actions

Authored by epriestley on Aug 2 2014, 7:09 PM.

Details

Reviewers

joshuaspence
btrahan

Maniphest Tasks

T4896: Move Audit to ApplicationTransactions

Commits

Restricted Diffusion Commit
rP508260e4fef1: Apply `diffusion.createcomment` directly with transaction editor in Audit

Summary

Ref T4896. Use the new transaction-oriented PhabricatorAuditEditor directly instead of invoking it via the old editor.

Test Plan

Used Conduit to add a comment, use silent mode, and accept a commit.

Diff Detail

Repository

rP Phabricator

Branch

audit4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2008
Build 2009: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24353.Aug 2 2014, 7:09 PM

epriestley retitled this revision from to Apply `diffusion.createcomment` directly with transaction editor in Audit.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, joshuaspence.

epriestley added a task: T4896: Move Audit to ApplicationTransactions.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 2 2014, 7:09 PM

Harbormaster completed remote builds in B2008: Diff 24353.Aug 2 2014, 7:10 PM

btrahan accepted this revision.Aug 2 2014, 7:15 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Aug 2 2014, 7:15 PM

Closed by commit rP508260e4fef1 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

editor/

PhabricatorAuditCommentEditor.php

7 lines

diffusion/

conduit/

DiffusionCreateCommentConduitAPIMethod.php

28 lines

Diff 24353

View Options

src/applications/audit/editor/PhabricatorAuditCommentEditor.php