Paths

Table of Contentst

Render Phame templates in the expected order
ClosedPublic
Actions

Authored by epriestley on Jul 29 2014, 1:47 AM.

Tags

None

Referenced Files

	F13222227: D10067.diff
	Sun, May 19, 3:26 AM

	F13204766: D10067.diff
	Wed, May 15, 12:55 AM

	F13188044: D10067.diff
	Sat, May 11, 4:57 AM

	Unknown Object (File)
	Tue, May 7, 8:07 AM

	Unknown Object (File)
	Fri, May 3, 7:48 AM

	Unknown Object (File)
	Thu, Apr 25, 7:04 PM

	Unknown Object (File)
	Thu, Apr 25, 7:04 PM

	Unknown Object (File)
	Thu, Apr 25, 2:09 AM

View All Files

Subscribers

epriestley

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rPf9fe5e3a60af: Render Phame templates in the expected order

Summary

Currently, content runs before header. Instead, run header, content, footer. This makes it easier to use header.php for includes, for Phacility.

Test Plan

Made Phacility blog work better, see next diff.

Diff Detail

Repository

rP Phabricator

Branch

phameorder

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1920
Build 1921: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24211.Jul 29 2014, 1:47 AM

epriestley retitled this revision from to Render Phame templates in the expected order.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 29 2014, 1:47 AM

Harbormaster completed remote builds in B1920: Diff 24211.Jul 29 2014, 1:48 AM

chad accepted this revision.Jul 29 2014, 2:06 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Jul 29 2014, 2:06 AM

Closed by commit rPf9fe5e3a60af (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

skins/

PhameBasicTemplateBlogSkin.php

9 lines

Diff 24211

View Options

src/applications/phame/skins/PhameBasicTemplateBlogSkin.php

Render Phame templates in the expected orderClosedPublicActions