Page MenuHomePhabricator
Differential D10044

Improve text mode rendering of reverse Remarkup list staircases
ClosedPublic
Actions

Authored by epriestley on Jul 24 2014, 11:20 PM.
Tags
None
Referenced Files
F15486731: D10044.id.diff
Thu, Apr 10, 9:13 AM
F15461287: D10044.id.diff
Tue, Apr 1, 7:00 AM
F15460540: D10044.id24140.diff
Mon, Mar 31, 11:50 PM
F15458597: D10044.diff
Mon, Mar 31, 5:21 AM
F15454206: D10044.id24165.diff
Sat, Mar 29, 4:57 PM
F15452391: D10044.id.diff
Sat, Mar 29, 4:26 AM
F15451188: D10044.diff
Fri, Mar 28, 8:41 PM
F15432785: D10044.id24165.diff
Mon, Mar 24, 7:38 PM
View All Files
Subscribers
epriestley

Details

Reviewers
asherkin
btrahan
chad
Maniphest Tasks
T5102: Markdown syntax of README.md file present in a repository is not well rendered
Commits
rPHU371c33b73585: Improve text mode rendering of reverse Remarkup list staircases
Summary

Ref T5102. The text-only mode of these was a bit silly.

Test Plan

Added and executed unit tests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24140.Jul 24 2014, 11:20 PM
epriestley retitled this revision from to Improve text mode rendering of reverse Remarkup list staircases.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: asherkin, chad, btrahan.
epriestley added a task: T5102: Markdown syntax of README.md file present in a repository is not well rendered.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 24 2014, 11:20 PM
Harbormaster completed remote builds in B1880: Diff 24140.Jul 24 2014, 11:21 PM
chad accepted this revision.Jul 25 2014, 4:06 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 25 2014, 4:06 AM
epriestley closed this revision.Jul 25 2014, 4:58 AM
epriestley updated this revision to Diff 24165.

Closed by commit rPHU371c33b73585 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
markup/
engine/
__tests__/
remarkup/
1 line
4 lines
remarkup/
blockrule/
79 lines

Diff 24165

View Options

src/markup/engine/__tests__/remarkup/list-crazystairs.txt

Loading...
View Options

src/markup/engine/__tests__/remarkup/list-staircase.txt

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupListBlockRule.php

Loading...
Phabricator · Built by Phacility