Fixes T5695. A Conduit "method does not exist" exception is somewhat expected... there is no need to phlog the exception.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T5695: Don't log Conduit "method does not exist" exceptions
- Commits
- Restricted Diffusion Commit
rPbff217efd314: Don't log Conduit 404s as errors
Called a non-existent Conduit method. Saw no exceptions in the error logs.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Seems fine to me, generally.
In the next iteration of Conduit, I'd like to push all the wacky error handling more heavily into exceptions, too. For example, we have like 20 methods that define some custom version of "you're trying to update an object which does not exist", and all of that should just be returning something like a 404 response (and maybe even just a 404 response literally).
Comment Actions
Yeah. We can rebalance the class tree later (e.g., have an abstract base and then a bunch of final subclasses) if necessary, but it's reasonable to put that off until the next significant iteration since it will probably muck with things anyway.