Page MenuHomePhabricator
Differential D10039

Simplify the implementation of `PhabricatorPolicyCapability` subclasses
ClosedPublic
Actions

Authored by joshuaspence on Jul 24 2014, 12:42 PM.
Tags
None
Referenced Files
F18361726: D10039.diff
Wed, Aug 27, 12:35 PM
F17955892: D10039.id24136.diff
Fri, Aug 1, 5:07 AM
F17935637: D10039.id24127.diff
Wed, Jul 30, 11:28 PM
F17854955: D10039.id.diff
Jul 27 2025, 3:44 PM
F17833250: D10039.diff
Jul 26 2025, 1:24 PM
Unknown Object (File)
Jun 19 2025, 12:28 AM
Unknown Object (File)
Jun 18 2025, 2:51 PM
Unknown Object (File)
Jun 18 2025, 8:29 AM
View All Files
Subscribers
epriestley
hach-que
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPb4d7a9de3912: Simplify the implementation of `PhabricatorPolicyCapability` subclasses
Summary

Instead of implementing the getCapabilityKey method in all subclasses of PhabricatorPolicyCapability, provide a final implementation in the base class which uses reflection. See D9837 and D9985 for similar implementations.

Test Plan

N/A

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 24127.Jul 24 2014, 12:42 PM
joshuaspence retitled this revision from to Simplify the implementation of `PhabricatorPolicyCapability` subclasses.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 24 2014, 12:42 PM
Herald added subscribers: hach-que, Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1875: Diff 24127.Jul 24 2014, 12:43 PM
epriestley accepted this revision.Jul 24 2014, 1:26 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 24 2014, 1:26 PM
joshuaspence closed this revision.Jul 24 2014, 10:25 PM
joshuaspence updated this revision to Diff 24136.

Closed by commit rPb4d7a9de3912 (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
src/
applications/
countdown/
capability/
4 lines
differential/
capability/
4 lines
diffusion/
capability/
4 lines
4 lines
4 lines
4 lines
4 lines
drydock/
capability/
4 lines
4 lines
4 lines
harbormaster/
capability/
4 lines
herald/
capability/
4 lines
legalpad/
capability/
4 lines
4 lines
4 lines
macro/
capability/
4 lines
maniphest/
capability/
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
nuance/
capability/
4 lines
4 lines
4 lines
oauthserver/
capability/
4 lines
paste/
capability/
4 lines
people/
capability/
4 lines
pholio/
capability/
4 lines
4 lines
phragment/
capability/
4 lines
policy/
capability/
4 lines
4 lines
4 lines
22 lines
project/
capability/
4 lines
slowvote/
capability/
4 lines

Diff 24136

View Options

src/applications/countdown/capability/PhabricatorCountdownDefaultViewCapability.php

Loading...
View Options

src/applications/differential/capability/DifferentialDefaultViewCapability.php

Loading...
View Options

src/applications/diffusion/capability/DiffusionCreateRepositoriesCapability.php

Loading...
View Options

src/applications/diffusion/capability/DiffusionDefaultEditCapability.php

Loading...
View Options

src/applications/diffusion/capability/DiffusionDefaultPushCapability.php

Loading...
View Options

src/applications/diffusion/capability/DiffusionDefaultViewCapability.php

Loading...
View Options

src/applications/diffusion/capability/DiffusionPushCapability.php

Loading...
View Options

src/applications/drydock/capability/DrydockCreateBlueprintsCapability.php

Loading...
View Options

src/applications/drydock/capability/DrydockDefaultEditCapability.php

Loading...
View Options

src/applications/drydock/capability/DrydockDefaultViewCapability.php

Loading...
View Options

src/applications/harbormaster/capability/HarbormasterManagePlansCapability.php

Loading...
View Options

src/applications/herald/capability/HeraldManageGlobalRulesCapability.php

Loading...
View Options

src/applications/legalpad/capability/LegalpadCreateDocumentsCapability.php

Loading...
View Options

src/applications/legalpad/capability/LegalpadDefaultEditCapability.php

Loading...
View Options

src/applications/legalpad/capability/LegalpadDefaultViewCapability.php

Loading...
View Options

src/applications/macro/capability/PhabricatorMacroManageCapability.php

Loading...
View Options

src/applications/maniphest/capability/ManiphestBulkEditCapability.php

Loading...
View Options

src/applications/maniphest/capability/ManiphestDefaultEditCapability.php

Loading...
View Options

src/applications/maniphest/capability/ManiphestDefaultViewCapability.php

Loading...
View Options

src/applications/maniphest/capability/ManiphestEditAssignCapability.php

Loading...
View Options

src/applications/maniphest/capability/ManiphestEditPoliciesCapability.php

Loading...
View Options

src/applications/maniphest/capability/ManiphestEditPriorityCapability.php

Loading...
View Options

src/applications/maniphest/capability/ManiphestEditProjectsCapability.php

Loading...
View Options

src/applications/maniphest/capability/ManiphestEditStatusCapability.php

Loading...
View Options

src/applications/nuance/capability/NuanceSourceDefaultEditCapability.php

Loading...
View Options

src/applications/nuance/capability/NuanceSourceDefaultViewCapability.php

Loading...
View Options

src/applications/nuance/capability/NuanceSourceManageCapability.php

Loading...
View Options

src/applications/oauthserver/capability/PhabricatorOAuthServerCreateClientsCapability.php

Loading...
View Options

src/applications/paste/capability/PasteDefaultViewCapability.php

Loading...
View Options

src/applications/people/capability/PeopleBrowseUserDirectoryCapability.php

Loading...
View Options

src/applications/pholio/capability/PholioDefaultEditCapability.php

Loading...
View Options

src/applications/pholio/capability/PholioDefaultViewCapability.php

Loading...
View Options

src/applications/phragment/capability/PhragmentCanCreateCapability.php

Loading...
View Options

src/applications/policy/capability/PhabricatorPolicyCanEditCapability.php

Loading...
View Options

src/applications/policy/capability/PhabricatorPolicyCanJoinCapability.php

Loading...
View Options

src/applications/policy/capability/PhabricatorPolicyCanViewCapability.php

Loading...
View Options

src/applications/policy/capability/PhabricatorPolicyCapability.php

Loading...
View Options

src/applications/project/capability/ProjectCreateProjectsCapability.php

Loading...
View Options

src/applications/slowvote/capability/PhabricatorSlowvoteDefaultViewCapability.php

Loading...
Phabricator · Built by Phacility