Page MenuHomePhabricator
Differential D10005

Remove deprecated linter configuration
ClosedPublic
Actions

Authored by joshuaspence on Jul 21 2014, 9:58 PM.
Tags
None
Referenced Files
F14080992: D10005.diff
Fri, Nov 22, 5:55 PM
F14077934: D10005.id28186.diff
Fri, Nov 22, 1:26 AM
Unknown Object (File)
Thu, Nov 21, 1:51 PM
Unknown Object (File)
Wed, Nov 20, 7:37 PM
Unknown Object (File)
Mon, Nov 18, 4:55 PM
Unknown Object (File)
Tue, Nov 12, 7:45 AM
Unknown Object (File)
Tue, Nov 5, 11:16 AM
Unknown Object (File)
Thu, Oct 31, 7:26 AM
View All Files
Subscribers
aik099
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Commits
rARCaf343e4ca69f: Remove deprecated linter configuration
Summary

Removes the deprecated method of configuring linters (via the .arcconfig file). There is one main caveat here:

  • There is currently no convenient method by which to change the path for an external linter (T5057). This means that there is no direct replacement for the deprecated lint.ruby.prefix configuration. The workaround is to symlink these binaries into arcanist/externals/bin.
Test Plan

Wait a sufficient amount of time before landing this.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 6137
Build 6158: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

TimeTest
2,089 msArcanistXHPASTLinterTestCase::testLinter
856 msArcanistCSSLintLinterTestCase::testLinter
129 msArcanistCSSLintLinterTestCase::testVersion
34 msArcanistChmodLinterTestCase::testLinter
160 msArcanistClosureLinterTestCase::testLinter
View Full Test Results (1 Failed · 48 Passed · 3 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 24048.Jul 21 2014, 9:58 PM
joshuaspence retitled this revision from to [LATER] Remove deprecated linter configuration.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added reviewers: Blessed Reviewers, chad. · View Herald TranscriptJul 21 2014, 9:58 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1819: Diff 24048.Jul 21 2014, 9:59 PM
aik099 added a subscriber: aik099.Dec 5 2014, 9:10 AM

@joshuaspence , the deprecated configuration options you've removed allowed to configure external linters, but now there is now to do it, e.g. specify standard for PHPCS linter. Maybe you should add support for these option in .arclint file instead?

joshuaspence updated this revision to Diff 27583.Jan 22 2015, 9:30 PM
joshuaspence edited edge metadata.

Rebase

joshuaspence retitled this revision from [LATER] Remove deprecated linter configuration to Remove deprecated linter configuration.Jan 26 2015, 4:28 AM
aik099 added a comment.Jan 26 2015, 8:03 AM

@joshuaspence, is there alternative to these deprecated options. I'm especially interested with PHPCS linter (see my previous comment)?

joshuaspence added a comment.Jan 26 2015, 8:11 PM
In D10005#108908, @aik099 wrote:

@joshuaspence, is there alternative to these deprecated options. I'm especially interested with PHPCS linter (see my previous comment)?

See D11511.

joshuaspence updated this revision to Diff 28145.Feb 5 2015, 8:03 PM

Rebase

joshuaspence updated this revision to Diff 28186.Feb 8 2015, 8:06 PM

Retain default flags for cppcheck

joshuaspence updated this revision to Diff 28187.Feb 8 2015, 8:09 PM

Whitespace fix

joshuaspence updated this object.Feb 8 2015, 8:12 PM
epriestley accepted this revision.May 19 2015, 1:28 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 19 2015, 1:28 PM
joshuaspence updated this revision to Diff 31152.May 19 2015, 9:23 PM
joshuaspence edited edge metadata.

Rebase

joshuaspence added a child revision: D10541: Split the `ArcanistXHPASTLinter` into modular rules.May 20 2015, 12:09 PM
joshuaspence updated this revision to Diff 31201.May 20 2015, 9:00 PM

Rebase

joshuaspence updated this revision to Diff 31202.May 20 2015, 9:02 PM

Remove deprecated switch hook configuration

Closed by commit rARCaf343e4ca69f: Remove deprecated linter configuration (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 20 2015, 9:03 PM
This revision was automatically updated to reflect the committed changes.
avivey mentioned this in T8333: linters with deprecated configurations give hard-to-debug errors.May 27 2015, 11:48 PM

Revision Contents
Changeset List

Diff 31152

View Options

src/lint/linter/ArcanistCSSLintLinter.php

Loading...
View Options

src/lint/linter/ArcanistCppcheckLinter.php

Loading...
View Options

src/lint/linter/ArcanistCpplintLinter.php

Loading...
View Options

src/lint/linter/ArcanistFlake8Linter.php

Loading...
View Options

src/lint/linter/ArcanistJSHintLinter.php

Loading...
View Options

src/lint/linter/ArcanistLinter.php

Loading...
View Options

src/lint/linter/ArcanistPEP8Linter.php

Loading...
View Options

src/lint/linter/ArcanistPhpcsLinter.php

Loading...
View Options

src/lint/linter/ArcanistPyFlakesLinter.php

Loading...
View Options

src/lint/linter/ArcanistPyLintLinter.php

Loading...
View Options

src/lint/linter/ArcanistRubyLinter.php

Loading...
View Options

src/lint/linter/ArcanistScriptAndRegexLinter.php

Loading...
View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
Phabricator · Built by Phacility