Browsing through all other non-prototype applications and using them a bit to track down PHP8 incompatibilities.
Refs T13588
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T13588: PHP 8 Compatibility
- Commits
- rPcf400694c717: Addressing some PHP8 incompatibilities - Misc. Applications
I tried basic usage of the following applications which found & fixed:
- Almanac, creating resources, networks, services, etc.
- Drydock, creating blue prints
- Pholio mocks
- Setting up TOTP MFA
- Phame blog and post
- Creating default Space
- Creating and signing a legalpad document
- Creating a conpherence room
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- cspeck-php8-apps
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 25821 Build 35649: arc lint + arc unit
Event Timeline
| src/applications/metamta/exception/PhabricatorMetaMTAReceivedMailProcessingException.php | ||
|---|---|---|
| 17 ↗ | (On Diff #52163) | buh - the error I got from this led me to https://php.watch/versions/8.2/partially-supported-callable-deprecation. The backwards-compat notice at the bottom mentions ::class notation is available in 5.3+. I tried messing around with this in https://3v4l.org/E9eTR#v5.4.0 but nothing immediately stood out to me as functional in both 5.4 and 8.2. |